Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message tray and message list types #27

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Update message tray and message list types #27

merged 1 commit into from
Mar 28, 2024

Conversation

swsnr
Copy link
Collaborator

@swsnr swsnr commented Mar 28, 2024

Update message list and message tray types.

@swsnr
Copy link
Collaborator Author

swsnr commented Mar 28, 2024

I'm still testing these new types w/ my extension to see if I got everything alright, but I believe they're at least more correct for GNOME 46 than the current 45 types (which are pretty much wrong all around, since this part got a heavy makeover for GNOME 46).

So I think you can merge and release as is, and I'll make follow up PRs if I find mistakes or missing types.

Note that I sometimes took the lazy way and remove internal attributes (ie starting with _) and classes that were never exported to begin with, instead of meticulously going through every single type.

@JumpLink JumpLink merged commit 16261f8 into gjsify:main Mar 28, 2024
1 check passed
@JumpLink
Copy link
Collaborator

@swsnr Thank you!

@swsnr swsnr deleted the gnome46/notification-types branch March 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants