Port some types to GNOME 46 + some additional types #23

Totto16 · 2024-03-27T15:08:59Z

This ports some types to GNOME 46 and adds a new file:
ui/lightbox

This fixes only types, I need for an extension, and some things that changed, that I saw while doing that.

Totto16 · 2024-03-27T15:47:50Z

Same as #22 these are just the Basics, and I have some complex types that are not correct yet, but those need some deep investigation, from where they come and how to fix them, and I am yet unsure, if they are from gnome shell or from other packages, @JumpLink you mentioned, that the generated types might be incorrect, or do I remember incorrectly?

Anyways, I'll look into these, that might take some time

JumpLink · 2024-03-27T17:52:40Z

@Totto16 yes, the existing types might not be correct. So if you think there might be something wrong, go ahead and change it

JumpLink · 2024-03-27T17:54:50Z

@Totto16 , @swsnr It would also be okay for me to divide the PR's into small parts which we then merge to collect feedback

swsnr · 2024-03-28T08:30:34Z

@Totto16 In my MRs I marked every type which I added, update, or scrutinized for GNOME 46 with a /** @version 46 */ comment to keep track which types are already working with GNOME 46. Would you do the same in this PR?

I'm asking because I'm likely also going to touch the dialog modules when going through my extensions, so it'd help to see what's already been done.

Totto16 · 2024-03-28T15:09:59Z

@Totto16 In my MRs I marked every type which I added, update, or scrutinized for GNOME 46 with a /** @version 46 */ comment to keep track which types are already working with GNOME 46. Would you do the same in this PR?

I'm asking because I'm likely also going to touch the dialog modules when going through my extensions, so it'd help to see what's already been done.

Yeah, that's a good idea, I am going to do this too 👍🏼

…l/-/commit/3f72a04a1b9a1f0eb25a02095d3556b34e855881

…cted methods too

… methods and types

…, where I used an other Name

Totto16 · 2024-03-28T16:13:54Z

Edit: this is redundant, I removed it 👍🏼

This is ready now, I added something, that might be controversial, I can remove it, if you don't like it:

here

it says The format() function (see [printf](https://wikipedia.org/wiki/Printf_format_string)) is available for all strings, but should only be used with gettext functions. In all other cases you should use JavaScript's [Template Literals](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Template_literals).

So I thought, If it is a good idea, to type the returns of the gettext() etc. functions explicitly with that types, so you don't have to import the global types, and so you don't have the risk of using it anywhere else. I prefer this, since it enforces this on a type basis. But if you don't prefer this, I can remove that final commit from this PR, since importing the global types isn't that "bad" and this is just a proposal from my side...

Anyway, let me hear your opinion on that ❤️

swsnr · 2024-03-28T16:25:06Z

packages/gnome-shell/src/ui/modalDialog.d.ts

-    public open(timestamp: number, onPrimary: boolean): boolean;
-    public close(timestamp: number): boolean;
+    public open(): boolean;
+    //note: upstream has timestamp as paramater here, but it only will be used to call popModal, which doesn't accept that paramater anymore, so this is just a bug upstream


Is this issue reported to upstream and being fixed?

If so, why not add a link here? If not, perhaps report it, to clarify if it's a bug here or with popModal?

I intend to do that, but not yet 😓

The bug is clearly here, since the last commits seem to get rid of the timestamp parameter everywhere else, they just missed it here

made a MR on this issue: here

packages/gnome-shell/src/extensions/sharedInternals.d.ts

JumpLink · 2024-03-28T17:48:23Z

@Totto16 Thank you very much! Would you also be interested in becoming a maintainer? Then you could review and merge each other. It's a bit inconvenient that I'm not currently developing an extension myself 😅

Totto16 · 2024-03-28T18:02:32Z

@Totto16 Thank you very much! Would you also be interested in becoming a maintainer? Then you could review and merge each other. It's a bit inconvenient that I'm not currently developing an extension myself 😅

Yeah for sure, that helps a lot.
And yeah, I'd love to be a maintainer ❤️ 👍🏼
@swsnr already did a great review of the types, so that definitely helps, since he also works with the types and that helps a lot when revieweing

JumpLink · 2024-03-28T18:08:19Z

That makes me happy :) I have sent you an invite

swsnr · 2024-03-28T19:21:38Z

@Totto16 Thank you very much! Would you also be interested in becoming a maintainer? Then you could review and merge each other. It's a bit inconvenient that I'm not currently developing an extension myself 😅

@JumpLink Not sure if it was meant to be implied here, but just in case there's a misunderstanding I'd like to point out that I am not a collaborator here and do not have permission to merge things here 🙂

I was just reviewing these changes because I'm interested 🙂

JumpLink · 2024-03-28T23:33:43Z

Sorry @swsnr😅 your nickname is similar to @schnz 🫣

But it's great that more and more people are taking part and making such good contributions. You are very welcome :)

swsnr · 2024-03-29T06:47:35Z

Sorry @swsnr😅 your nickname is similar to @schnz 🫣

No worries 🙂

But it's great that more and more people are taking part and making such good contributions. You are very welcome :)

If it helps feel free to add me too 🙂

JumpLink · 2024-03-29T20:47:28Z

If it helps feel free to add me too

Send you an invite 📮

Totto16 marked this pull request as draft March 27, 2024 15:47

Totto16 mentioned this pull request Mar 27, 2024

Update gnome 46 types oae/gnome-shell-pano#265

Merged

13 tasks

swsnr mentioned this pull request Mar 27, 2024

Port some types to GNOME 46 #22

Merged

Totto16 added 5 commits March 28, 2024 16:20

fix MonitorConstraint constructor types

d02fb16

add ui/lightbox types

743f7e0

fix modalDialog open(), see https://gitlab.gnome.org/GNOME/gnome-shel…

c3e227d

…l/-/commit/3f72a04a1b9a1f0eb25a02095d3556b34e855881

fix types of dialog and modalDialog "addButton"

7f90a46

fix dialog / MessageDialogContent constructor types

df8168c

Totto16 force-pushed the fixes branch from cb3441a to df8168c Compare March 28, 2024 15:21

Totto16 added 5 commits March 28, 2024 16:34

add version comment and double check things in ui/dialog

4dfa3d0

add version specifier to checked classes in ui/layout

b9bed50

add version specifier to checked classes in ui/lightbox and add prote…

fed605e

…cted methods too

add version specifier to checked classes in ui/modalDialog and update…

5229b0a

… methods and types

use namespace and "export interface ConstructorProperties" everywhere…

ff64e4b

…, where I used an other Name

Totto16 marked this pull request as ready for review March 28, 2024 16:00

swsnr reviewed Mar 28, 2024

View reviewed changes

Totto16 force-pushed the fixes branch from b36f8ca to ff64e4b Compare March 28, 2024 16:33

JumpLink merged commit 311b6f6 into gjsify:main Mar 28, 2024
2 checks passed

Totto16 deleted the fixes branch March 28, 2024 17:47

Totto16 mentioned this pull request Sep 20, 2024

Adapt typings for Gnome 47 release #51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port some types to GNOME 46 + some additional types #23

Port some types to GNOME 46 + some additional types #23

Totto16 commented Mar 27, 2024 •

edited

Loading

Totto16 commented Mar 27, 2024 •

edited

Loading

JumpLink commented Mar 27, 2024 •

edited

Loading

JumpLink commented Mar 27, 2024 •

edited

Loading

swsnr commented Mar 28, 2024

Totto16 commented Mar 28, 2024

Totto16 commented Mar 28, 2024 •

edited

Loading

swsnr Mar 28, 2024

Totto16 Mar 28, 2024

Totto16 Mar 28, 2024

Totto16 Mar 28, 2024

JumpLink commented Mar 28, 2024

Totto16 commented Mar 28, 2024

JumpLink commented Mar 28, 2024

swsnr commented Mar 28, 2024

JumpLink commented Mar 28, 2024 •

edited

Loading

swsnr commented Mar 29, 2024

JumpLink commented Mar 29, 2024

Port some types to GNOME 46 + some additional types #23

Port some types to GNOME 46 + some additional types #23

Conversation

Totto16 commented Mar 27, 2024 • edited Loading

Totto16 commented Mar 27, 2024 • edited Loading

JumpLink commented Mar 27, 2024 • edited Loading

JumpLink commented Mar 27, 2024 • edited Loading

swsnr commented Mar 28, 2024

Totto16 commented Mar 28, 2024

Totto16 commented Mar 28, 2024 • edited Loading

swsnr Mar 28, 2024

Choose a reason for hiding this comment

Totto16 Mar 28, 2024

Choose a reason for hiding this comment

Totto16 Mar 28, 2024

Choose a reason for hiding this comment

Totto16 Mar 28, 2024

Choose a reason for hiding this comment

JumpLink commented Mar 28, 2024

Totto16 commented Mar 28, 2024

JumpLink commented Mar 28, 2024

swsnr commented Mar 28, 2024

JumpLink commented Mar 28, 2024 • edited Loading

swsnr commented Mar 29, 2024

JumpLink commented Mar 29, 2024

Totto16 commented Mar 27, 2024 •

edited

Loading

Totto16 commented Mar 27, 2024 •

edited

Loading

JumpLink commented Mar 27, 2024 •

edited

Loading

JumpLink commented Mar 27, 2024 •

edited

Loading

Totto16 commented Mar 28, 2024 •

edited

Loading

JumpLink commented Mar 28, 2024 •

edited

Loading