Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return type #16

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add missing return type #16

merged 1 commit into from
Jan 3, 2024

Conversation

swsnr
Copy link
Collaborator

@swsnr swsnr commented Jan 3, 2024

Fix implicit "any" return type

@swsnr
Add missing return type
2a24d04 
Fix implicit "any" return type
@swsnr
Copy link
Collaborator Author

swsnr commented Jan 3, 2024

@JumpLink I'm sorry, I messed this up in #15 😬

Would you make another release with this fix included? It's not critical, but it's not nice to have an implicit any return type in a function that just doesn't return anything 😇

@JumpLink JumpLink merged commit 1ccacb4 into gjsify:main Jan 3, 2024
@JumpLink
Copy link
Collaborator

JumpLink commented Jan 3, 2024

@swsnr Thanks and published 👍

@swsnr swsnr deleted the patch-1 branch January 3, 2024 18:13
@swsnr
Copy link
Collaborator Author

swsnr commented Jan 3, 2024

Thanks a lot ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swsnr @JumpLink