Merge pull request #29 from swsnr/tsconfig-strictest

Inherit @tsconfig/strictest
gjsify · Mar 29, 2024 · 77a185b · 77a185b
2 parents 0be3416 + 9da0814
commit 77a185b
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,11 +23,11 @@ jobs:
           - x64
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         submodules: true
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
     - run: yarn install

diff --git a/examples/hello-world/package.json b/examples/hello-world/package.json
@@ -14,6 +14,7 @@
   "author": "Pascal Garber <pascal@artandcode.studio>",
   "license": "MIT",
   "devDependencies": {
+    "@tsconfig/strictest": "^2.0.5",
     "adm-zip": "^0.5.12",
     "esbuild": "^0.20.2",
     "typescript": "5.4.3"

diff --git a/examples/hello-world/src/extension.ts b/examples/hello-world/src/extension.ts
@@ -7,9 +7,13 @@ import PanelMenu from '@girs/gnome-shell/ui/panelMenu';
 import * as Main from '@girs/gnome-shell/ui/main';
 
 export default class ExampleExtension extends Extension {
-    _indicator: PanelMenu.Button;
+    private _indicator: PanelMenu.Button | null = null;
+
+    override enable() {
+        if (this._indicator !== null) {
+            return;
+        }
 
-    enable() {
         // Create a panel button
         this._indicator = new PanelMenu.Button(0.0, this.metadata.name, false);
 
@@ -24,7 +28,7 @@ export default class ExampleExtension extends Extension {
         Main.panel.addToStatusArea(this.uuid, this._indicator);
     }
 
-    disable() {
+    override disable() {
         this._indicator?.destroy();
         this._indicator = null;
     }

diff --git a/examples/hello-world/tsconfig.json b/examples/hello-world/tsconfig.json
@@ -1,4 +1,5 @@
 {
+    "extends": "@tsconfig/strictest/tsconfig.json",
     "compilerOptions": {
         "lib": ["ESNext"],
         "types": [],

diff --git a/packages/gnome-shell/package.json b/packages/gnome-shell/package.json
@@ -943,6 +943,7 @@
     "@girs/upowerglib-1.0": "^0.99.1-3.3.0"
   },
   "devDependencies": {
+    "@tsconfig/strictest": "^2.0.5",
     "typescript": "5.4.3"
   },
   "keywords": [

diff --git a/packages/gnome-shell/tsconfig.json b/packages/gnome-shell/tsconfig.json
@@ -1,17 +1,12 @@
 {
+    "extends": "@tsconfig/strictest/tsconfig.json",
     "compilerOptions": {
         "lib": ["ESNext"],
         "types": [],
         "target": "ESNext",
         "module": "ESNext",
         "moduleResolution": "Bundler",
-        "strict": true,
-        "noImplicitAny": true,
-        "strictNullChecks": true,
-        "noImplicitThis": true,
-        "alwaysStrict": true,
-        "strictPropertyInitialization": true,
-        "allowSyntheticDefaultImports": true
+        "skipLibCheck": false
     },
     "include": ["./dist/**/*.d.ts"],
     "files": ["./dist/index.d.ts"]

diff --git a/yarn.lock b/yarn.lock
@@ -490,6 +490,7 @@ __metadata:
     "@girs/shew-0": "npm:^0.0.0-3.3.0"
     "@girs/st-14": "npm:^14.0.0-3.3.0"
     "@girs/upowerglib-1.0": "npm:^0.99.1-3.3.0"
+    "@tsconfig/strictest": "npm:^2.0.5"
     typescript: "npm:5.4.3"
   languageName: unknown
   linkType: soft
@@ -870,12 +871,20 @@ __metadata:
     "@girs/gnome-shell": "workspace:^"
     "@girs/gobject-2.0": "npm:^2.78.0-3.3.0"
     "@girs/st-14": "npm:^14.0.0-3.3.0"
+    "@tsconfig/strictest": "npm:^2.0.5"
     adm-zip: "npm:^0.5.12"
     esbuild: "npm:^0.20.2"
     typescript: "npm:5.4.3"
   languageName: unknown
   linkType: soft
 
+"@tsconfig/strictest@npm:^2.0.5":
+  version: 2.0.5
+  resolution: "@tsconfig/strictest@npm:2.0.5"
+  checksum: 10/c1dfc581c6b46218034aa05a0ea2d0284ae8dc3508a38bee7014dd6868ed681e6b88d4d13a8e1b7f35221e84cd020ffab18f3991bc9e652ce441775e2fcbad57
+  languageName: node
+  linkType: hard
+
 "adm-zip@npm:^0.5.12":
   version: 0.5.12
   resolution: "adm-zip@npm:0.5.12"