Skip to content

Commit

Permalink
Fix t4047 under valgrind.
Browse files Browse the repository at this point in the history
valgrind-3.15.0 works fine, but with valgrind-3.19.0 (at least on Arch),
this test fails with an open pipe detected. I don't think testing this
under valgrind/helgrind is particularly useful, so just disable them for
this test.
  • Loading branch information
gittup committed Jul 30, 2022
1 parent d7de132 commit b037d4b
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/t4047-open-fds.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
# Make sure a sub-process only has the minimum necessary fds open.
. ./tup.sh

# Later versions of valgrind have a pipe open that this test picks up and
# erroneously fails.
unset TUP_HELGRIND
unset TUP_VALGRIND

if [ ! "$tupos" = "Linux" ]; then
echo "Sub-process fds only checked under linux. Skipping test."
eotup
Expand Down

0 comments on commit b037d4b

Please sign in to comment.