Added max length validation in user registration, company name and password which solve unhandled error in backend #495
Conversation
…led error in backend
|
@ArafatHossain403 is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request introduces additional validation constraints to the Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
libraries/nestjs-libraries/src/dtos/auth/create.org.user.dto.ts (1)
5-10: Password validation looks good, consider additional security measuresThe 64-character limit is reasonable and aligns with common security practices. However, consider adding additional password complexity requirements.
Consider adding these validators for stronger password security:
@IsString() @MinLength(3) @MaxLength(64) +@Matches(/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d\W]{3,}$/, { + message: 'Password must contain uppercase, lowercase, and numbers' +}) @IsDefined()
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libraries/nestjs-libraries/src/dtos/auth/create.org.user.dto.ts(1 hunks)
🔇 Additional comments (3)
libraries/nestjs-libraries/src/dtos/auth/create.org.user.dto.ts (3)
1-1: LGTM! Import statement correctly includes MaxLength validator
The import statement properly includes the new MaxLength validator while maintaining other necessary imports.
26-30: LGTM! Company name validation is well-structured
The 128-character limit for company names is reasonable and the validation chain is complete with appropriate minimum and maximum length constraints.
16-19: Verify provider token length requirements
Consider adding MaxLength validation for providerToken based on the maximum token length of supported providers.
| @IsEmail() | ||
| @IsDefined() | ||
| @ValidateIf((o) => !o.providerToken) | ||
| email: string; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider adding MaxLength validation for email field
While email validation is present, consider adding a MaxLength validator to prevent excessive input lengths, similar to other fields.
@IsEmail()
@IsDefined()
@ValidateIf((o) => !o.providerToken)
+@MaxLength(254) // RFC 5321 maximum length
email: string;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @IsEmail() | |
| @IsDefined() | |
| @ValidateIf((o) => !o.providerToken) | |
| email: string; | |
| @IsEmail() | |
| @IsDefined() | |
| @ValidateIf((o) => !o.providerToken) | |
| @MaxLength(254) // RFC 5321 maximum length | |
| email: string; |
What kind of change does this PR introduce?
Bug Fix: Resolves issues with excessive input lengths for password and company name during user registration.
Use 64 characters for passwords and 128 characters for company names. This strikes a balance between practicality, security, and efficiency.
Why was this change needed?
Related Issues:
#493
#494
Both issues stemmed from the absence of well-defined input length restrictions for the password and company fields during the user registration process.
Other information:
Enforced a maximum character limit for password and company fields:
Password: Max 64 characters.
Company Name: Max 128 characters.
Future plans: Extend similar validation rules to other input fields across the application.
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;
Summary by CodeRabbit
New Features
Style