Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet][dotnet-vnc] Fix image builds #218

Merged
merged 2 commits into from
May 2, 2020
Merged

[dotnet][dotnet-vnc] Fix image builds #218

merged 2 commits into from
May 2, 2020

Conversation

@jankeromnes
Copy link
Contributor Author

Still fails with:

Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package dotnet-sdk-3.1
E: Couldn't find any package by glob 'dotnet-sdk-3.1'
E: Couldn't find any package by regex 'dotnet-sdk-3.1'

I guess the fall back is to drop the .deb file and install binaries instead, as described in: https://dev.to/carlos487/installing-dotnet-core-in-ubuntu-20-04-6jh

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 30, 2020

New approach. Still left to do:

  • Re-install fsharp and mono-complete
  • Install mono-devel to fix fsharpi (i.e. absorb Fix fsharpi #195)

@jankeromnes jankeromnes changed the title [dotnet][dotnet-vnc] Try using apt-transport-https [dotnet][dotnet-vnc] Fix image builds May 1, 2020
@jankeromnes
Copy link
Contributor Author

Woohoo, it worked! 🎉

Screenshot 2020-05-01 at 11 58 29

@jankeromnes
Copy link
Contributor Author

Ok, so the new Ubuntu 20.04 gitpod/workspace-dotnet* images now build successfully again.

However, I don't know .NET well enough to know whether it's okay to just install:

  • .NET Core SDK 3.1
  • mono-complete
  • fsharp

We used to (potentially) install a few extra things, e.g.:

  • The previous image used ACCEPT_EULA=Y apt-get -y -f -o APT::Install-Suggests="true" install instead of just apt-get install -y. Will we miss anything important if we don't install suggested packages?

  • In Fix fsharpi #195, mono-devel was also installed (in addition to mono-complete). Is that needed, e.g. to fix fsharpi?

@JesterOrNot @simonelnahas @jhuizingh Would you have any insights on the questions above?

Otherwise, I guess the next step would be to test the new images, and see if they work with "real" .NET projects:

  • gitpod/workspace-dotnet:branch-jx-fix-dotnet
  • gitpod/workspace-dotnet-vnc:branch-jx-fix-dotnet

@jankeromnes
Copy link
Contributor Author

Well, I guess "maybe fixed" is better than "definitely broken", so I'll merge this PR, and we can make any adjustments as follow-up PRs.

Thanks again for your patience and help! Let's make .NET development in Gitpod awesome. 🚀

@jankeromnes jankeromnes merged commit 197b9ad into master May 2, 2020
@jhuizingh
Copy link

Sorry, meant to respond sooner. I think just the sdk is good for what I'm trying to do.

@jankeromnes
Copy link
Contributor Author

No worries (and in fact, sorry for being hasty, even though it's a prolonged weekend...) Many thanks for your reply! 🙏

@jankeromnes jankeromnes mentioned this pull request May 11, 2020
@princerachit princerachit deleted the jx/fix-dotnet branch March 7, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants