Homebrew autofix #1487
Homebrew autofix #1487
Conversation
|
Taking a look meow |
| const version = data.tag_name; | ||
|
|
||
| const patchVersionReplacements = { | ||
| '4\\.[0-9][0-9]*\\.[0-9][0-9]*': version, |
There was a problem hiding this comment.
This will help avoid major version updates, nice!
💡 we could reference the desired value in a chunk yaml file (like we do with lang-node and NODE_VERSION), this way we would not hard code "4" here in the regex. However, this is not necessary now, I think. Approving to unblock!
There was a problem hiding this comment.
That's a nice idea of specifying the version in a chunk, but I am hesitant to do it because of the nondeterministic nature of our upgrades of homebrew (see https://github.com/gitpod-io/workspace-images/pull/1487/files#diff-0c0646c5f75103e0991b9322a68f0f8ad25f71cec07eb1a7b4e8744ad884a6a3R7-R9). We can get rid of the hardcoded major, though.
There was a problem hiding this comment.
the version I am referring would only be used here, in the autofix, it wouldn't be used by the dockerfile to install a specific version.
There was a problem hiding this comment.
either way, what you have here is nice, and will help autofix minor and patch changes, which is a nice improvement.
does the major version change often, or do we expect it to change soon?
There was a problem hiding this comment.
Oh, I see now, let's leave it as-is then. The last major release was in Feb 2023 and the one before that in Feb 2021, so mayyybe a biyearly cadence (or just a coincidence 😄)?
I have GH notifications set up on the releases there so if a major does come out, I'll get to bring it here sooner or later.
Description
A hacky way to rebuild Homebrew when a new one comes out.