Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null pointer exception on export download #382

Closed
PhilippeVienne opened this issue Jun 10, 2019 · 2 comments
Closed

Null pointer exception on export download #382

PhilippeVienne opened this issue Jun 10, 2019 · 2 comments

Comments

@PhilippeVienne
Copy link
Contributor

With gitlab.com the "Content-Disposition" is not given, it causes a null pointer here on line 112:
https://github.com/gitlab4j/gitlab4j-api/blob/master/src/main/java/org/gitlab4j/api/ImportExportApi.java#L111-L113
PhilippeVienne added a commit to smartfire-archive/gitlab4j-api that referenced this issue Jun 10, 2019
@PhilippeVienne
Fix for null pointer gitlab4j#382
308760a
PhilippeVienne added a commit to smartfire-archive/gitlab4j-api that referenced this issue Jun 10, 2019
@PhilippeVienne
Prefer path over name to avoid spaces and special characters in file …
4da9ae6 
…name gitlab4j#382
PhilippeVienne added a commit to smartfire-archive/gitlab4j-api that referenced this issue Jun 10, 2019
@PhilippeVienne
Added filename parameter for download function gitlab4j#382
5c3f632
PhilippeVienne added a commit to smartfire-archive/gitlab4j-api that referenced this issue Jun 10, 2019
@PhilippeVienne
Remove fallback for a never happen situation gitlab4j#382
1dfb47e
gmessner pushed a commit that referenced this issue Jun 10, 2019
@PhilippeVienne @gmessner
Fix for null pointer #382 (#383)
2228180 
* Fix for null pointer #382
* Added method with filename parameter for download function #382
@gmessner
Copy link
Collaborator

@PhilippeVienne
This has been released in 4.11.8. Please verify and close when you have the time.

Thanks again for your contribution.

@PhilippeVienne
Copy link
Contributor Author

@gmessner
Thanks, it works 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhilippeVienne @gmessner