Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add view state to method modeling panel #2918

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add view state to method modeling panel #2918

merged 1 commit into from
Oct 6, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Oct 6, 2023

This adds a view state to the method modeling panel similar to the model editor. This will be used to send the state of the show multiple models feature flag to the webview so this can be used to selectively show/hide components in the method modeling panel.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Add view state to method modeling panel
cf0057e 
This adds a view state to the method modeling panel similar to the
model editor. This will be used to send the state of the show multiple
models feature flag to the webview so this can be used to selectively
show/hide components in the method modeling panel.
koesie10
koesie10 commented Oct 6, 2023
View reviewed changes
extensions/ql-vscode/src/view/method-modeling/MethodModeling.tsx
@@ -40,6 +40,7 @@ export type MethodModelingProps = {
modelingStatus: ModelingStatus;
method: Method;
modeledMethod: ModeledMethod | undefined;
showMultipleModels?: boolean;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to have some way to use the viewState in the MethodModelingView, so this is just to make use of the viewState for now. In a follow-up PR, this will be used.

@koesie10 koesie10 marked this pull request as ready for review October 6, 2023 12:08
@koesie10 koesie10 requested review from a team as code owners October 6, 2023 12:08
charisk
charisk approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and happy to get it merged.

However, it's hard to know what is a "view state" and what isn't so if we're planning to add more things to this we should perhaps have a discussion/make things clearer.

@koesie10
Copy link
Member Author

koesie10 commented Oct 6, 2023

However, it's hard to know what is a "view state" and what isn't so if we're planning to add more things to this we should perhaps have a discussion/make things clearer.

I agree. For now, we're only planning on adding this, I don't think there's anything else we would be adding here soon.

@koesie10 koesie10 merged commit 2410d2b into main Oct 6, 2023
25 checks passed
@koesie10 koesie10 deleted the koesie10/modeling-panel-view-state branch October 6, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk