Remove excessive logging statements

github · Jan 29, 2025 · 3a8f2b5 · 3a8f2b5
1 parent 71de463
commit 3a8f2b5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/go/pools/smartconnpool/pool.go b/go/pools/smartconnpool/pool.go
@@ -379,7 +379,6 @@ func (pool *ConnPool[C]) put(conn *Pooled[C]) {
 		var err error
 		conn, err = pool.connNew(context.Background())
 		if err != nil {
-			log.Errorf("======================== connNew ERROR: %s", err)
 			pool.closedConn()
 			return
 		}
@@ -525,7 +524,6 @@ func (pool *ConnPool[C]) get(ctx context.Context) (*Pooled[C], error) {
 	}
 	// no connections available and no connections to wait for (pool is closed)
 	if conn == nil {
-		log.Errorf("====================== ERROR: conn == nil err")
 		return nil, ErrTimeout
 	}
 
@@ -584,7 +582,6 @@ func (pool *ConnPool[C]) getWithSetting(ctx context.Context, setting *Setting) (
 	}
 	// no connections available and no connections to wait for (pool is closed)
 	if conn == nil {
-		log.Errorf("====================== getWithSetting ERROR: conn == nil err")
 		return nil, ErrTimeout
 	}
 

diff --git a/go/vt/vttablet/tabletserver/query_executor.go b/go/vt/vttablet/tabletserver/query_executor.go
@@ -697,14 +697,12 @@ func (qre *QueryExecutor) execSelect() (*sqltypes.Result, error) {
 	}
 	// Check tablet type.
 	if qre.shouldConsolidate() {
-		log.Error("============================== WE'RE CONSOLIDATING")
 		q, original := qre.tsv.qe.consolidator.Create(sqlWithoutComments)
 		if original {
 			defer q.Broadcast()
 			conn, err := qre.getConn()
 
 			if err != nil {
-				log.Errorf("=========================== ERROR WHEN TRYING TO GET CONNECTION WHEN CONSOLIDATING: %s", err)
 				q.SetErr(err)
 			} else {
 				defer conn.Recycle()
@@ -725,15 +723,12 @@ func (qre *QueryExecutor) execSelect() (*sqltypes.Result, error) {
 	}
 	conn, err := qre.getConn()
 	if err != nil {
-		log.Errorf("====================== ERROR WHEN TRYING TO GET CONNECTION FROM POOL: %s", err.Error())
 		return nil, err
 	}
 	defer conn.Recycle()
 
-	log.Info("====================== NO ERROR WHEN TRYING TO GET CONNECTION FROM POOL")
 	res, err := qre.execDBConn(conn.Conn, sql, true)
 	if err != nil {
-		log.Errorf("=========================== ERROR WHEN EXECUTING WITH CONNECTION: %s", err.Error())
 		return nil, err
 	}
 	return res, nil

diff --git a/go/vt/vttablet/tabletserver/tabletserver.go b/go/vt/vttablet/tabletserver/tabletserver.go
@@ -1561,7 +1561,6 @@ func (tsv *TabletServer) execRequest(
 
 	err = exec(ctx, logStats)
 	if err != nil {
-		log.Errorf("============================ EXEC ERROR: %s", err.Error())
 		return tsv.convertAndLogError(ctx, sql, bindVariables, err, logStats)
 	}
 	return nil