-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"mailto" links, possibly with optional Subject, not rendering correctly #1030
Comments
Hey there! 👋 This actually has to do with URL requirements per the CommonMark spec. CommonMark does not allow for spaces in URLs, so you need to encode those as
You can review CommonMark's definition of a URL (link destination) here: |
Thank you! |
Spaces are not allowed in the URL, so the link is broken. Spaces in the URL should be encoded as `%20` to make the link be rendered correctly. See also: github/markup#1030
Per discussion on [this issue](github/markup#1030), mailto links with subjects must have spaces URL-encoded.
Thank you for posting this. I was here battling to figure out how to add support e-mail to the README.md |
FIxed spacing issue that prevented mailto link from appearing correctly. Found solution here: github/markup#1030
Thank you! shawnajean, you best in hub!
I would recommend the extension to other friends - VS-extension (If you are using Visual Studio) And THIS EDITHOR (A little harder to customize for yourself, but a VERY POWERFUL md-editor) |
Thanks for the sugestion. I hadn't seen such a powerful Markdown tool yet.
An excellent choice to study!
Em sáb., 10 de abr. de 2021 às 19:59, Yuri Morozov ***@***.***>
escreveu:
… Thank you!
*shawnajean*, you best in hub!
I would recommend the extension to other friends - VS-extension
<https://marketplace.visualstudio.com/items?itemName=MadsKristensen.MarkdownEditor> *(If
you are using Visual Studio)*
And THIS EDITHOR <https://pandao.github.io/editor.md/en.html> *(A little
harder to customize for yourself, but a VERY POWERFUL md-editor)*
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1030 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOSITDQ3BT2CM7NQOONMVDTIDJ45ANCNFSM4DEW3YCQ>
.
|
Thanks! Was looking for a way to add my E-mail Address Link to my Readme.md |
In Source Han Sans and other projects in our organization, the use of mailto is not working, perhaps when an optional Subject is specified.
The following is specified:
[Dr. Ken Lunde](mailto:lunde@adobe.com?subject=[GitHub] Source Han Sans)
This is expected to be rendered as only Dr. Ken Lunde, but when clicked, will initiate an email in the default email client with "[GitHub] Source Han Sans" specified as the default Subject.
Instead, I see the literal markdown, per the screenshot below:
This happens regardless of the Browser: Chrome, Firefox, and Safari running on macOS Version 10.12.3.
The text was updated successfully, but these errors were encountered: