Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how gh-ost (via go-lang) handles non-alphabetical enums in primary keys #273

Closed
ggunson opened this issue Oct 17, 2016 · 1 comment
Closed

Investigate how gh-ost (via go-lang) handles non-alphabetical enums in primary keys #273

ggunson opened this issue Oct 17, 2016 · 1 comment
Assignees
@shlomi-noach
Labels
bug data-integrity

Comments

@ggunson
Copy link
Contributor

ggunson commented Oct 17, 2016

Based on the bug report for pt-online-schema-change: https://bugs.launchpad.net/percona-toolkit/+bug/1613915

tl;dr: For pt-osc, enums in primary keys weren't handled correctly (the enum values were seen as their names vs their index numbers) if the values weren't in alphabetical order already. http://dev.mysql.com/doc/refman/5.6/en/enum.html#enum-sorting

The fix for pt-osc is already merged: percona/percona-toolkit#131

It's worth testing if this is handled correctly here with gh-ost too.
@shlomi-noach shlomi-noach self-assigned this Oct 19, 2016
shlomi-noach pushed a commit that referenced this issue Oct 19, 2016
testing enum as part of PK
3986696 
reference: #273

enum values are intentionally not alphabetically monotonic
@shlomi-noach shlomi-noach mentioned this issue Oct 19, 2016
Merged
@shlomi-noach
Copy link
Contributor

closed by #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomi-noach shlomi-noach

Labels
bug data-integrity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shlomi-noach @ggunson