-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gh models view
command
#6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh models view
commandgh models view
command and update run
model validation
Necessary for fetching details of a particular model.
Only used in two places, and I'm not convinced I like the light gray + underline for the 'view' command.
Only used there now, after fixing merge conflicts.
Labelling keywords as tags and lowercasing them like we do to present on the Models Marketplace.
gh models view
command and update run
model validationgh models view
command
Better display of tables and links.
sgoedecke
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
@@ -234,7 +234,7 @@ func NewRunCommand() *cobra.Command { | |||
|
|||
foundMatch := false | |||
for _, model := range models { | |||
if strings.EqualFold(model.FriendlyName, modelName) || strings.EqualFold(model.Name, modelName) { | |||
if model.HasName(modelName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
I feel like such a rebel, merging this without any passing tests. 😅 I swear it works on my machine, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I referenced the kind of information shown on a page like https://github.com/marketplace/models/azure-openai/gpt-4o-mini. I think there's still additional formatting we could do on the output produced, but I thought this was a good enough first pass to get some kind of details view in there.
Sample output: