Increase test coverage, split up some files #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only thing remaining in 'ux' package, and it's operating just on an azuremodels type.
cheshire137
commented
Oct 15, 2024
There was a problem hiding this comment.
I brought these tests over from https://github.com/Azure/azure-sdk-for-go/blob/4661007ca1fd68b2e31f3502d4282904014fd731/sdk/ai/azopenai/event_reader_test.go.
cheshire137
commented
Oct 15, 2024
There was a problem hiding this comment.
The type is EventReader so I wanted the file name to match.
cheshire137
commented
Oct 15, 2024
| @@ -6,7 +6,6 @@ import ( | |||
|
|
|||
| "github.com/cli/go-gh/v2/pkg/tableprinter" | |||
| "github.com/github/gh-models/internal/azuremodels" | |||
| "github.com/github/gh-models/internal/ux" | |||
There was a problem hiding this comment.
This package was able to go away because its two functions made more sense elsewhere, either as a method on a type rather than a standalone function (IsChatModel) or because the function dealt with types defined in another package (SortModels).
There was a problem hiding this comment.
Yep, I agree that's a sensible move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given our EventReader type came from another repo:
gh-models/internal/sse/eventreader.go
Line 1 in 01a3cee
I also wanted to bring over the tests from the same referenced repository.
This branch generally increases test coverage. I split up the types.go file by pulling out any type to its own file if it had any methods on it.
Test coverage for this branch:
% go test -race -cover ./... github.com/github/gh-models coverage: 0.0% of statements ok github.com/github/gh-models/cmd (cached) coverage: 78.9% of statements ok github.com/github/gh-models/cmd/list (cached) coverage: 93.1% of statements ok github.com/github/gh-models/cmd/run (cached) coverage: 47.2% of statements ok github.com/github/gh-models/cmd/view (cached) coverage: 80.0% of statements ok github.com/github/gh-models/internal/azuremodels (cached) coverage: 73.2% of statements ok github.com/github/gh-models/internal/sse (cached) coverage: 58.1% of statements github.com/github/gh-models/pkg/command coverage: 0.0% of statements github.com/github/gh-models/pkg/util coverage: 0.0% of statements