Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example of terraform-registry configuration #6808

Merged
merged 8 commits into from
Jun 2, 2021
Merged

docs: add example of terraform-registry configuration #6808

merged 8 commits into from
Jun 2, 2021

Conversation

xlgmokha
Copy link
Contributor

@xlgmokha xlgmokha commented May 26, 2021

Why:

This change introduces documentation for configuring terraform private registries for use by Dependabot.

/xref: https://github.com/github/dependabot-updates/issues/1480

What's being changed:

A new section was added to https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#configuration-options-for-private-registries.

Screen Shot 2021-05-26 at 12 54 03

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 26, 2021
@janiceilene
Copy link
Contributor

@xlgmokha I see this is still in draft mode. Let me know when you're ready for a writer review 💖

@xlgmokha
Copy link
Contributor Author

I see this is still in draft mode. Let me know when you're ready for a writer review 💖

Will do. Thanks Janice.

@xlgmokha xlgmokha marked this pull request as ready for review May 28, 2021 18:56
@xlgmokha
Copy link
Contributor Author

I think this is ready. Back to you @janiceilene.

@xlgmokha xlgmokha requested review from asciimike and janiceilene May 28, 2021 20:09
@github github deleted a comment May 28, 2021
asciimike
asciimike previously approved these changes May 28, 2021
Copy link
Contributor

@asciimike asciimike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes; otherwise, LGTM

…dencies-updated-automatically/configuration-options-for-dependency-updates.md

Co-authored-by: Mike McDonald <2575327+asciimike@users.noreply.github.com>
…dencies-updated-automatically/configuration-options-for-dependency-updates.md

Co-authored-by: Mike McDonald <2575327+asciimike@users.noreply.github.com>
@janiceilene
Copy link
Contributor

Thanks @xlgmokha! I've triaged this for writer review ⚡

@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review codeql Content related to CodeQL dependabot Content related to Dependabot and removed triage Do not begin working on this issue until triaged by the team codeql Content related to CodeQL labels May 28, 2021
@mchammer01 mchammer01 self-assigned this Jun 1, 2021
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xlgmokha - LGTM ✨

@mchammer01 mchammer01 removed the waiting for review Issue/PR is waiting for a writer's review label Jun 1, 2021
@mchammer01 mchammer01 added the ready to merge This pull request is ready to merge label Jun 1, 2021
@janiceilene janiceilene merged commit a759ece into github:main Jun 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@xlgmokha xlgmokha deleted the updates-1480-terraform-registries branch June 2, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot Content related to Dependabot ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants