Provide example of boolean input usage #15349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many people are confused by the usage of boolean. actions/runner#1483 invalid if: ${{ inputs.perform_deploy }} if: inputs.perform_deploy Must be treated as string
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@tevans-submittable Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
|
This seems like a reasonable change. Thanks @tevans-submittable 👍 |
lecoursen
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Thanks @tevans-submittable, this looks great! It looks like there's a merge conflict that you'll need to resolve before we can merge and publish this. Please ping us in for another review after you've done that!
|
Had issues due to filename lengths, new branch and PR - #16028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Many people are confused by the usage of boolean. actions/runner#1483
invalid
if: ${{ inputs.perform_deploy }}
if: inputs.perform_deploy
Must be treated as string
if: ${{ inputs.perform_deploy == 'true' }}
What's being changed:
Update examples of the usage of workflow inputs of type boolean
Check off the following:
Writer impact (This section is for GitHub staff members only):