Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: extend paths-ignore to all rust/ql #18352

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

redsun82
Copy link
Contributor

This will also exclude code examples in rust/ql/src/queries.

This will also exclude code examples in `rust/ql/src/queries`.
@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 15:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@geoffw0
Copy link
Contributor

geoffw0 commented Jan 2, 2025

Excluding code examples from analysis SGTM.

Does this affect QL-for-QL?

@redsun82
Copy link
Contributor Author

redsun82 commented Jan 6, 2025

Excluding code examples from analysis SGTM.

Does this affect QL-for-QL?

Ah, good question, hadn't thought about that. It doesn't, as QL-for-QL configuration is done here

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@redsun82 redsun82 merged commit 2e1e46c into main Jan 6, 2025
8 checks passed
@redsun82 redsun82 deleted the redsun82/rust-codeql-config branch January 6, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants