Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into releases/v3 #2732

Merged
merged 25 commits into from
Jan 27, 2025
Merged

Merge main into releases/v3 #2732

merged 25 commits into from
Jan 27, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 27, 2025 •
edited by aeisenberg
Loading

Merging b494190 into releases/v3.

Conductor for this PR is @aeisenberg.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v3 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Mark the PR as ready for review to trigger the full set of PR checks.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.
  • Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.

henrymercer and others added 25 commits January 24, 2025 13:21
@henrymercer
Add missing permissions
d390659
@henrymercer
Give only read-level security-events permission where possible
9cd802e
@henrymercer
Merge branch 'main' into henrymercer/add-permissions
3b34c67
@henrymercer
Merge pull request #2720 from github/henrymercer/add-permissions
c22d1f3 
Restrict workflow permissions
@github-actions
Update changelog and version after v3.28.5
da67fa0
@github-actions
Update checked-in dependencies
336c69e
@henrymercer
Merge branch 'main' into mergeback/v3.28.5-to-main-f6091c01
4b8aeab
@marcogario
Fix bug in getCredentials + tests
51bb5eb
@dbartol
Merge pull request #2722 from github/mergeback/v3.28.5-to-main-f6091c01
e7c0c9d 
Mergeback v3.28.5 refs/heads/releases/v3 into main
@marcogario
Sanitize inputs
ecf7232
@marcogario
Formatting
f6d19ed
@aeisenberg
Ensure artifacts are only uploaded in safe situations
2bab9f7 
This commit:

Turns on uploading of artifacts again but only if CLI version is
>= 2.20.3. I implemented the check using our feature flag functionality.
I was on the fence about this since it makes the PR more complex.
However, it does give us more flexibility when controlling artifact
uploads.

Also, I renamed the two workflows that were previously disabled. This
way we will not accidentally enable the old workflows for previous
versions of the action.
@aeisenberg
Update changelog
5ff2464
@aeisenberg
Stop using feature-flag support for determining if a feature is active
f71067b 
Using the feature flag mechanism for checking if uploads are enabled was
too clunky. I'm moving the change to checking versions directly.
@aeisenberg
Fix CLI versions
346d067
@aeisenberg
Iterate over each version
a2c1b36 
Not sure why we need this now, but didn't before.
@marcogario
Use ConfigureationError for exceptions
7c2eafa
@dependabot
build(deps-dev): bump the npm group with 4 updates
7fdbca3 
Bumps the npm group with 4 updates: [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js), [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [nock](https://github.com/nock/nock).


Updates `@eslint/js` from 9.18.0 to 9.19.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.19.0/packages/js)

Updates `@typescript-eslint/eslint-plugin` from 8.21.0 to 8.22.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.22.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.21.0 to 8.22.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.22.0/packages/parser)

Updates `nock` from 13.5.6 to 14.0.0
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md)
- [Commits](nock/nock@v13.5.6...v14.0.0)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm
- dependency-name: nock
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: npm
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
Update checked-in dependencies
357e0ce
@aeisenberg
Merge pull request #2723 from github/marcogario/start-proxy_tests
297e89a 
start-proxy: Fix bug when language is not provided
@aeisenberg
Merge pull request #2731 from github/dependabot/npm_and_yarn/npm-e1e9…
c6b2861 
…e6cd15

build(deps-dev): bump the npm group with 4 updates
@aeisenberg
Add better comments around artifact upload tests
62c322f
@aeisenberg
Clarify test fail;ure message
a879704
@aeisenberg
Merge pull request #2726 from github/aeisenberg/reenable-artifact-upload
b494190 
Ensure artifacts are only uploaded in safe situations
@github-actions
Update changelog for v3.28.6
64ad47c
@aeisenberg aeisenberg marked this pull request as ready for review January 27, 2025 20:09
@Copilot Copilot bot review requested due to automatic review settings January 27, 2025 20:09
@aeisenberg aeisenberg requested a review from a team as a code owner January 27, 2025 20:09
Copilot
Copilot AI reviewed Jan 27, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 458 out of 458 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
@aeisenberg aeisenberg enabled auto-merge January 27, 2025 20:10
@aeisenberg aeisenberg merged commit 4e83f6b into releases/v3 Jan 27, 2025
261 of 262 checks passed
@aeisenberg aeisenberg deleted the update-v3.28.6-b49419044 branch January 27, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@TUMFILLAF17 TUMFILLAF17 TUMFILLAF17 approved these changes

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees

@aeisenberg aeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aeisenberg @TUMFILLAF17 @henrymercer @marcogario @dbartol