Set ArtifactV4Upgrade
's default value to true
#2633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
artifacts@v3
has an official deprecation date of December 5. Technically, merging this PR does not actually change much — the feature flags will first check the GitHub API for the value of the feature flag (which has been rolled out at 100% enabled for several weeks).In the future, we will remove the actual feature flag in GitHub's internal feature flag portal. Once this is done, the default
true
value set in this PR will be actually used in production. We don't want to yet remove the feature flag from the internal feature flag portal, as old versions of the CodeQL Action will use a default value offalse
if the flag is not found from the GItHub API, and use the deprecated version ofactions@v3
. Therefore we will only be able to remove the feature flag from the internal feature flag portal once we no longer support these older versions of the Action.Note that GHES customers will continue to use
artifacts@v3
until it is supported on GHES.Merge / deployment checklist