-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Rust color #4319
Improve Rust color #4319
Conversation
The Rust color on GitHub doesn't look much like rust, and I don't see where it could have come from (not on the website or part of the logo). In fact, it looks rather pale and sickly, rather than vibrant and robust. #a62c00 is much nicer. It resembles the red paints that have traditionally been made with iron oxide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmaddams Thanks!
@pmaddams Small tip for future reference: if you put a hex colour-code inside backticks, GitHub will display a preview for it:
|
Personally not a fan of the new color, it looks too similar to Ruby. |
I'm also quite against this change, it was clear cut from ruby or D, now it's something in between. I even thought I'd be at the wrong place before, please change it back. |
That's shitty colour |
I am marveled that all comments on the color representing Rust code are arguing on aesthetic grounds. The main job of linguist – as far as I understand it – is making it easy to spot in which language a given source code is written. Thus linguist does its job best if colors stay the same. I don't think it is important what color is chosen for Rust as long as no one ends up intuitively thinking that Rust itself is written in Scala. As this is happening with me right now I consider this change a bug and not a feature. |
@dschuessler that was exactly my intention when I called for changing it back. |
That's really bad |
I like new color. Give it symbolic meaning: "warm blood", "fresh blood". |
Why's this happening ? The submitter is not even a rust user |
oh, no .... I don't like new color . o(╥﹏╥)o |
oh, no .... I don't like new color . o(╥﹏╥)o |
1 similar comment
oh, no .... I don't like new color . o(╥﹏╥)o |
I don't like the new color. How can you do this without the agree of the Rust community? |
Please change the color back. |
Everyone is used to the old color. BTW, gitlab is still using it. Why this change? |
Ok ok ok. I hear you. I hear you. I'll revert and get a new release out and up on GitHub before GitLab has a chance to update Linguist there, yup they use it too 😉, and you all head over that way to request the same change. Locking any further comments. |
The Rust color on GitHub doesn't look much like rust, and I don't see where it could have come from (not on the website or part of the logo). In fact, it looks rather pale and sickly, rather than vibrant and robust.
#a62c00 is much nicer. It resembles the red paints that have traditionally been made with iron oxide.