[view] Remote Git config에서 owner, repo 정보를 View에서 받는 방식 수정 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxxjinn
reviewed
Oct 15, 2024
| initRef.current = true; | ||
| } | ||
| }, [handleChangeAnalyzedData, handleChangeBranchList, ideAdapter, setLoading]); | ||
|
|
||
| useEffect(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#588
Result
AS-IS
owner,repo정보를 vscode에서 view로 전달하기 위해 새로운EventListner를 추가하여 해당EventListner에postMessage하는 방식이었습니다.TO-BE
owner,repo정보를 fetch하는 방식으로csmDict,branches정보와 생명 주기가 갖도록 수정하였습니다.Work list
sendFetchAnalyzedDataMessage,sendFetchBranchListMessage할 때,sendFetchGithubInfo가 함께 실행되어owner,repo정보를 zustandstore에 할당 합니다.sendMessageToIDE를 사용하여 별도의EventListner를 추가하지 않도록 수정하였습니다.Discussion
owner,repo상태의 초기값을 'githru', 'githru-vscode-ext'로 하여 dev 모드에서도 issue number 링크를 테스트할 수 있도록 하였습니다.undefined, 공란 등이 되어야 할 것 같은데, 특정 레포지토리로 지정되어 있는 것은 수정되어야 하는 부분인 것 같습니다. 🤔