[engine] 최대 쓰레드 수 3개 제한 및 git 로그 최초 한 번만 불러오기 #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Oct 6, 2024
| @@ -220,8 +220,11 @@ export async function fetchGitLogInParallel(gitPath: string, currentWorkspacePat | |||
|
|
|||
| const totalCnt = await getLogCount(gitPath, currentWorkspacePath); | |||
| let numberOfThreads = 1; | |||
| if(totalCnt > 1000) numberOfThreads = Math.max(numCores/2,1); | |||
| console.log("thread nums ",numberOfThreads); | |||
| if(totalCnt > 1000){ | |||
There was a problem hiding this comment.
대부분의 value 들은 변수로 저장하는 것이 좋습니다!
추후 수정에 대비하는 것도 있지만,
이게 어떤 의미를 가지는 값인지 표현하기 위해서이기도 합니다!
| if(totalCnt > 1000) numberOfThreads = Math.max(numCores/2,1); | ||
| console.log("thread nums ",numberOfThreads); | ||
| if(totalCnt > 1000){ | ||
| if(numCores < 4) numberOfThreads = 2; |
| try { | ||
| const baseBranchName = (payload && JSON.parse(payload)) ?? (await fetchCurrentBranch()); | ||
| const storedAnalyzedData = context.workspaceState.get<ClusterNode[]>( | ||
| `${ANALYZE_DATA_KEY}_${baseBranchName}` | ||
| ); | ||
| let analyzedData = storedAnalyzedData; | ||
| analyzedData = storedAnalyzedData; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Result
Work list
fetchClusterNodes에 있던fetchGitLogInParallel함수 밖으로 이전baseBranchName함수 제거Discussion
혹시 위 작업을 마지막으로 해당 브랜치를 메인 브랜치와 병합해도 괜찮을까요?