feat(view): add cloc linechart #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloc 차트를 구현하였습니다. 차후 수정해야할 부분을 주석의 TODO로 정리 해두었습니다.
hanseul-lee
approved these changes
Sep 8, 2022
kmin-jeong
approved these changes
Sep 8, 2022
Comment on lines
+19
to
+22
|
|
||
| export const getCloc = (d: CommitNode) => | ||
| d.commit.diffStatistics.insertions + d.commit.diffStatistics.deletions; | ||
|
|
There was a problem hiding this comment.
@pshdev1030 님 이 부분 로직이
d.commit.diffStatistics.insertions - d.commit.diffStatistics.deletions;가 되어야 할 거 같은데 확인부탁드려요!
d보다는 좀 더 직관적인 변수명을 쓰면 좋을거 같아요! (ex: commitNode, node)- cloc관련 로직이라서 함수 위치가
TemPoralFilter/ClocLineChart/ClocLineChart.util.ts에 좀 더 적합할 거 같은데 어떻게 생각하시나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloc 차트를 구현하였습니다.
차후 수정해야할 부분을 주석의 TODO로 정리 해두었습니다.
민정님과 같이 수정할 예정입니다! @kmin-jeong