Support for extension #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2024 14:41
takezoe
reviewed
Jan 2, 2024
|
Sorry, I missed this pull request for long 🙇♂️ This is very interesting so I'm now taking a close look to see if we can merge this for the next markedj release. |
takezoe
reviewed
Jan 4, 2024
src/main/java/io/github/gitbucket/markedj/extension/Extension.java
Outdated
Show resolved
Hide resolved
takezoe
reviewed
Jan 4, 2024
src/main/java/io/github/gitbucket/markedj/extension/Extension.java
Outdated
Show resolved
Hide resolved
unused methods removed
takezoe
reviewed
Jan 4, 2024
takezoe
reviewed
Jan 4, 2024
|
@thmarx Sorry, I have two more comments. |
continue if any extension matches
takezoe
reviewed
Jan 4, 2024
takezoe
approved these changes
Jan 5, 2024
|
Thank you for your contribution! |
|
By the way, it would be great if you can also update README since this added a new option and the notification extension. |
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've added simple support for custom extension and want to know what you think about it.
Current state is really simple and maybe there are some code changes needed.
As an example extension, I've used the Notification extension from a pull request (#12).