BugFix: missing jpg content type breaks corrupts presentation for Office365 #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitbrent
approved these changes
Dec 12, 2018
|
Thanks @antonandreyev ! I have not experienced problems with images on office.com, so thanks for the information and the patch.
|
gitbrent
added a commit
that referenced
this pull request
Dec 12, 2018
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
…-type-missing BugFix: missing jpg content type breaks corrupts presentation for Office365
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we add only "jpeg" into presentation's content types (see makeXmlContTypes function) but Office365 definitely expects to see "jpg" also and consider some presentations as corrupted depending on certain pictures inserted.