Charts: lineShadow option #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 11, 2017 09:53
…ndles defaults for not passed options. Used in creating text element.
…applied fo chart data line.
* no shadow state handled * shadow props correction moved to a separate function and used when creating a line chart
gitbrent
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
lineShadowthat accepts the same object as text shadow option and enables author to hide the shadow when'none'set.createShadowElementthat transforms shadow options (merged with defaults) toa:innerShdwora:outerShdwelement.correctShadowOptionsthat performs validity checks (originally, this check was included inaddTextfunction, but now it's required in line chart as well) and corrects the values if needed.lineSizeoption – I've found out it had been already implemented but not mentioned in docs).Note: I've added the possibility to pass
nonestring instead of an object to thelineShadowproperty to enforce hiding the shadow. It preserves backward compatibility (currently, data line shadow is visible by default). But personally, no shadow should be used by default in general I think. I'd suggest not to display any shadow until thelineShadowproperty is set (then, usingnonewouldn't be needed anymore). But it corrupts backward compatibility. However, this is a decision up to you, @gitbrent 🙂