Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot set property 'lIns' of undefined #879

Closed
CroniD opened this issue Jan 1, 2021 · 1 comment
Closed

TypeError: Cannot set property 'lIns' of undefined #879

CroniD opened this issue Jan 1, 2021 · 1 comment
Assignees
@gitbrent
Labels
issue:bug
Milestone
3.4.0

Comments

@CroniD
Copy link

CroniD commented Jan 1, 2021

Hi there,

in

PptxGenJS/src/gen-xml.ts

Line 415 in 8d81999

slideItemObj.options._bodyProp.lIns = valToPts(slideItemObj.options.margin[0] || 0)
is a check missing for slideItemObj.options._bodyProp.

Best regards
@gitbrent gitbrent self-assigned this Jan 3, 2021
@gitbrent gitbrent added this to the 3.4.0 milestone Jan 3, 2021
@gitbrent
Copy link
Owner

gitbrent commented Jan 3, 2021

A default is added when the object is instantiated in the addTextDefinition() method:

PptxGenJS/src/gen-objects.ts

Line 903 in ea85a79

if (!opt._bodyProp) opt._bodyProp = {}

However, I agree that's a poor design.

A local check has been added:
Screen Shot 2021-01-02 at 19 59 37

Thanks @CroniD !

@gitbrent gitbrent closed this as completed Jan 3, 2021
gitbrent added a commit that referenced this issue Jan 3, 2021
@gitbrent
fix for Issue #879
3b82794
gitbrent added a commit that referenced this issue Jan 3, 2021
@gitbrent
added Issue #879
55b0a71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitbrent gitbrent

Labels
issue:bug
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
2 participants
@CroniD @gitbrent