-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
callback support for save method #40
Comments
Hi @ellisgl , Thanks for opening an Issue and supplying the code! Change has been implemented (I've added the filename as a return value to the callback function) and the |
My presentations have a lot of images, so I use plenty of async/awaits while generating a PPTX, the save "filename" callback fires too early in my case. I saw that a Promise for save is coming in 3.0 https://github.com/gitbrent/PptxGenJS/blob/master/CHANGELOG.md, is there already a quick fix I can apply to the code while waiting for the full release? |
My temporary fix for the saveCallback firing too early for whatever reason in Electron is saving as a node buffer, then saving the buffer as a '.pptx' in my own app. |
Version 3.0 will be released very soon and returns a Promise with every save method. |
I was noticing that I was sending the file before it was update and would like to have a callback fired after the file is written.
The text was updated successfully, but these errors were encountered: