Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set valAxisMinVal to 0 #357

Closed
girign opened this issue Jun 19, 2018 · 1 comment
Closed

Cannot set valAxisMinVal to 0 #357

girign opened this issue Jun 19, 2018 · 1 comment
Assignees
@gitbrent
Labels
issue:bug
Milestone
2.3.0

Comments

@girign
Copy link

girign commented Jun 19, 2018

The if condition in line 3355 of pptxgen.js would return false if opts.valAxisMinVal is 0 and therefore it won't be set.
@gitbrent gitbrent self-assigned this Jul 7, 2018
@gitbrent gitbrent added this to the 2.3.0 milestone Jul 7, 2018
gitbrent added a commit that referenced this issue Jul 7, 2018
@gitbrent
Fix for Issue #357
48e9a84
gitbrent added a commit that referenced this issue Jul 7, 2018
@gitbrent
added Issue #357
5cf7cf8
@gitbrent
Copy link
Owner

gitbrent commented Jul 7, 2018

Thanks @GiridharGNair !

@gitbrent gitbrent closed this as completed Jul 7, 2018
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
@gitbrent
Fix for Issue gitbrent#357
913b1bb
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
@gitbrent
added Issue gitbrent#357
353bd2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitbrent gitbrent

Labels
issue:bug
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@gitbrent @girign