Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default text size in empty cells making row height too big #193

Closed
mreilaender opened this issue Sep 19, 2017 · 1 comment
Closed

Default text size in empty cells making row height too big #193

mreilaender opened this issue Sep 19, 2017 · 1 comment
Assignees
Milestone

Comments

@mreilaender
Copy link
Contributor

mreilaender commented Sep 19, 2017

When a cell in a row doesn't contain text it's default text size is 18. This makes the height of the row too big (see below)
row_height_too_big

Compairision when every cell contains text
row_height_ok

I know its a duplicate (#20) but no solution was provided

gitbrent pushed a commit that referenced this issue Sep 21, 2017
@gitbrent gitbrent self-assigned this Sep 21, 2017
@gitbrent gitbrent added this to the 1.9.0 milestone Sep 21, 2017
@gitbrent
Copy link
Owner

Hi @mreilaender ,

Thanks for reporting this! The fix for Issue #20 got clobbered somewhere along the way to the current version of the text parsing engine and was not working correctly.

Empty cells are now formatted correctly in the current codebase:

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();

slide.addTable(
	['using null','2','3','4','5','',null,undefined],
	{ x:0.5, y:0.5, w:9 },
	{ fill:'F1F2F3', font_size:12, color:'363636', border:{pt:'1', color:'BBCCDD'} }
);

pptx.save('PptxGenJS-Issue193');

screen shot 2017-09-20 at 22 39 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants