-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SourceTree and Tortoise Git do not detect an installed git for windows. #208
Comments
See #152. This is due to the fact that the |
I have an idea. We could re-add the @nalla what do you think? |
@dscho I think its a sound plan. Because its just the Git wrapper it would be a minimal size impact. Best let the |
I'd actually also like the Portable Git users to benefit (remember, a variation of Portable Git is available with GitHub for Windows, and GitHub essentially sponsored all of the Git for Windows 2.x push). |
If I remember correctly SourceTree also uses an internal portable release that will eventually be pushed to Git for Windows 2.x. So that indeed makes sense. So I think both release scripts have to be adapted then. |
Given the downstream users control which version of PortableGit they're using, any extra hoops to jump through aren't really worth it. Adapting to the new structure isn't that hard, but if environments have to support 1.9.x and 2.x at the same time perhaps the workaround is necessary. |
For backwards-compatibility, we now copy appropriately adjusted versions of the Git wrapper into /bin/ so that e.g. TortoiseGit/SourceTree find the same executables as before. This addresses git-for-windows/git#208 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I implemented this and published it as part of the 3rd release candidate. Please test, everybody! |
Seems to work fine for me with the current SourceTree release except that SourceTree's "Terminal" button tries to open a command prompt via /bin/sh.exe which obviously fails. I got it to work properly by creating a symlink /bin/sh.exe -> /bin/bash.exe. Perhaps an sh.exe redirector needs to be put in /bin as well? |
It was pointed out in git-for-windows/git#208 that SourceTree expects `/bin/sh.exe` to be available. Let's just install the redirector to make SourceTree happy, too. This is a companion patch to fd137f7 (installer/portable: copy redirectors into /bin/{bash,git}.exe, 2015-06-19). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@nogaff please note that this commit should fix the issue (not by symlinking because that does not work in general, but simply by copying; it's just 29kB, so I think that's fine). |
FYI - Sourcetree's current beta worked around this issue (https://www.sourcetreeapp.com/update/WindowsReleaseNotes_public_beta.html):
|
@JoshSchreuder thanks for the update! |
…ost/gvfs-helper-robust-retry-take2 gvfs-helper: auto-retry after network errors, resource throttling, split GET and POST semantics
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Includes commits from these pull requests: git-for-windows#191 git-for-windows#205 git-for-windows#206 git-for-windows#207 git-for-windows#208 git-for-windows#215 git-for-windows#220 git-for-windows#221 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Yesterday I've installed the RC2 of the current release to test this on my private development environment before I use it at work.
After installing the 64bit version I entered the tortoise git settings to see, witch version gets detected here. I got a dialog here mentioned that it was tortoise was not able to detect the correct version string.
The label showing the version installed however showed version 2.4.3.1.
Ignoring this fact I started SourceTree. Short time after that the dialog to choose a versioning tool popped up.
So it seems there is a problem right now to detect the installed version of your tool. Maybe this problem does not exist using the 32bit version that was not tested by me.
The text was updated successfully, but these errors were encountered: