Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ditch the view get API call in one2many for the moment #864

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mguellsegarra
Copy link
Collaborator

@mguellsegarra mguellsegarra merged commit e89afa4 into v2 Jan 29, 2025
1 check passed
@mguellsegarra mguellsegarra deleted the fix/ditch-view-get-on-one2many branch January 29, 2025 09:24
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
## [2.59.2](v2.59.1...v2.59.2) (2025-01-29)

### Bug Fixes

* ditch the view get API call in one2many for the moment ([#864](#864)) ([e89afa4](e89afa4))
mguellsegarra added a commit that referenced this pull request Jan 29, 2025
* fix: improve action separator and treeactions bar

* feat: extract toolbar behaviour to hooks

gisce/webclient#1646

* feat: improve actionbar components with react best practices

gisce/webclient#1646

* feat: add new localization strings and improve One2many top bar

gisce/webclient#1646
- Added new localization strings for creating, searching, and navigating items in Catalan, English, and Spanish.
- Enhanced the One2many input components to utilize the toolbar from the current view, improving user experience and consistency across the application.

* feat: improve form handling and toolbar integration in One2many components

gisce/webclient#1646
- Added formRef to improve form submission handling in the FormActionBar and useFormToolbarButtons hooks.
- Refactored One2manyForm to support forwarding refs, enabling better integration with form functionalities.
- Updated One2manyInput and One2manyInputInfinite to utilize formRef for improved form management.
- Enhanced One2manyTopBar to integrate formRef and streamline toolbar button actions.

These changes improve the overall user experience and maintainability of the One2many components.

* feat: allow use of hooks from one2many's

* Merge branch 'v2' into feat/add-toolbar-buttons-to-x2many

* fix: bad conflict resolution

* fix: adjust sharebutton for formactionbar

* fix: remove unused function

* fix: adjust value key filtering in URL sharing

- Added "parent_id" to the allowed values keys in URL parameters
- Updated useUrlFromCurrentTab to include form values in the actionRawData.
- Modified RootView to merge filtered values with global values
- Ensured getPlainValues in Form handles potential null values for getValues and getFields.

* fix: improve value merging logic in useUrlFromCurrentTab

- Updated the logic to prioritize form values over action values for non-tree views.
- For tree views with active_ids, merged form values with action values.
- Simplified the final action data structure by directly assigning merged values.

* fix: improve and export parameter filtering

* fix: transform initialView to initialViewId

* fix: also clear url when closing all tabs

* chore(release): 2.58.1 [skip ci]

## [2.58.1](v2.58.0...v2.58.1) (2025-01-28)

### Bug Fixes

* adjust value key filtering in URL sharing ([9fd9d6a](9fd9d6a))
* also clear url when closing all tabs ([bf072e5](bf072e5))
* clear title when no tabs ([68d42f0](68d42f0))
* improve and export parameter filtering ([c79c3e0](c79c3e0))
* improve value merging logic in useUrlFromCurrentTab ([1b5d7dd](1b5d7dd))
* transform initialView to initialViewId ([28fff0a](28fff0a))

* feat: fetch toolbar if needed and if view of one2many is hardcoded

gisce/webclient#1646

* fix: temporally disable toolbar in one2many's until we decide which design path follow

* chore(release): 2.59.0 [skip ci]

# [2.59.0](v2.58.1...v2.59.0) (2025-01-28)

### Bug Fixes

* adjust sharebutton for formactionbar ([b9f3d30](b9f3d30))
* bad conflict resolution ([6c09769](6c09769))
* improve action separator and treeactions bar ([c520994](c520994))
* remove unused function ([c68ec43](c68ec43))
* temporally disable toolbar in one2many's until we decide which design path follow ([7470e76](7470e76))

### Features

* add new localization strings and improve One2many top bar ([0081027](0081027))
* allow use of hooks from one2many's ([0419afe](0419afe))
* extract toolbar behaviour to hooks ([1600b5c](1600b5c))
* fetch toolbar if needed and if view of one2many is hardcoded ([6251874](6251874))
* improve actionbar components with react best practices ([4e8627e](4e8627e))
* improve form handling and toolbar integration in One2many components ([4d82eac](4d82eac))

* fix: restore bad conflict resolution

* chore(release): 2.59.1 [skip ci]

## [2.59.1](v2.59.0...v2.59.1) (2025-01-28)

### Bug Fixes

* restore bad conflict resolution ([fd9d10f](fd9d10f))

* fix: ditch the view get API call in one2many for the moment (#864)

gisce/webclient#1745

* chore(release): 2.59.2 [skip ci]

## [2.59.2](v2.59.1...v2.59.2) (2025-01-29)

### Bug Fixes

* ditch the view get API call in one2many for the moment ([#864](#864)) ([e89afa4](e89afa4))

---------

Co-authored-by: Marc Güell Segarra <marc@ondori.dev>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
# [2.61.0-rc.1](v2.60.0...v2.61.0-rc.1) (2025-02-03)

### Bug Fixes

* adjust fixed height in graph components in forms ([92fc5bd](92fc5bd))
* adjust version for ooui.js in develop env ([6736d53](6736d53))
* adjust workflows to block concurrency ([7541d68](7541d68))
* allow clear in selection fields ([3617265](3617265))
* avoid duplicate requests in fetch column state ([ff4bf9b](ff4bf9b))
* avoid more duplicate requests ([d4c3a00](d4c3a00))
* change version ([3d33c50](3d33c50))
* **char:** allow many2one and selection value for widget char ([d3f140c](d3f140c))
* sync changes from v2 to v2-develop ([aa592fe](aa592fe))
* sync changes from v2 to v2-develop ([0acf50f](0acf50f))
* sync changes from v2 to v2-develop ([0938ae1](0938ae1))
* sync changes from v2 to v2-develop ([#681](#681)) ([7ef76f3](7ef76f3))
* sync changes from v2 to v2-develop ([#696](#696)) [skip ci] ([de342ee](de342ee))
* sync changes from v2 to v2-develop ([#700](#700)) ([2e5a2d7](2e5a2d7))
* sync changes from v2 to v2-develop ([#761](#761)) [skip ci] ([5571d3c](5571d3c))
* sync changes from v2 to v2-develop ([#787](#787)) [skip ci] ([a184f58](a184f58))
* sync changes from v2 to v2-develop ([#789](#789)) [skip ci] ([0d09dd4](0d09dd4))
* sync changes from v2 to v2-develop ([#799](#799)) [skip ci] ([6d1865a](6d1865a))
* sync changes from v2 to v2-develop ([#802](#802)) [skip ci] ([cccbe01](cccbe01))
* sync changes from v2 to v2-develop ([#837](#837)) [skip ci] ([34da7ca](34da7ca))
* sync changes from v2 to v2-develop ([#862](#862)) [skip ci] ([b7bb47b](b7bb47b))
* sync changes from v2 to v2-develop ([#866](#866)) ([bd86e89](bd86e89)), closes [#864](#864) [#864](#864)
* update gisce/fiber-diagram to v2.1.1-rc.1 ([bb29eca](bb29eca))
* update gisce/ooui to v2.1.0-rc.1 ([dbdb3a3](dbdb3a3))
* update gisce/ooui to v2.10.1-rc.1 ([#586](#586)) ([3f3b52f](3f3b52f))
* update gisce/ooui to v2.16.1-rc.1 ([e760440](e760440))
* update gisce/ooui to v2.2.1-rc.1 ([cdb346f](cdb346f))
* update gisce/ooui to v2.6.1-rc.1 ([83ab8be](83ab8be))
* update gisce/react-formiga-components to v1.2.1-rc.1 ([d8be556](d8be556))
* update gisce/react-formiga-components to v1.2.2-rc.1 ([9bad6f4](9bad6f4))
* update gisce/react-formiga-components to v1.3.2-rc.1 ([50b0002](50b0002))
* update gisce/react-formiga-components to v1.4.0-rc.1 ([ef364db](ef364db))

### Features

* **char:** allow many2one and selection value for widget char ([da90aff](da90aff))
* sync changes from v2 to v2-develop ([18906c7](18906c7))
* sync changes from v2 to v2-develop ([9eb0e0a](9eb0e0a))
* sync changes from v2 to v2-develop ([814aa46](814aa46))
* sync changes from v2 to v2-develop ([#694](#694)) [skip ci] ([91fe817](91fe817))
* sync changes from v2 to v2-develop ([#702](#702)) ([999832f](999832f))
* sync changes from v2 to v2-develop ([#712](#712)) [skip ci] ([7d5a2e7](7d5a2e7))
* sync changes from v2 to v2-develop ([#716](#716)) [skip ci] ([28edbf6](28edbf6))
* sync changes from v2 to v2-develop ([#733](#733)) [skip ci] ([54a5e93](54a5e93))
* sync changes from v2 to v2-develop ([#743](#743)) ([6714ab7](6714ab7))
* sync changes from v2 to v2-develop ([#767](#767)) ([247cffe](247cffe))
* sync changes from v2 to v2-develop ([#778](#778)) [skip ci] ([e206bfa](e206bfa))
* sync changes from v2 to v2-develop ([#783](#783)) [skip ci] ([b761a38](b761a38))
* sync changes from v2 to v2-develop ([#794](#794)) [skip ci] ([e90b414](e90b414))
* sync changes from v2 to v2-develop (🚨 CONFLICTS RESOLVED) ([#724](#724)) [skip ci] ([8db3627](8db3627))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant