feat: add extraction of enums from markers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedHamouGisaia
approved these changes
Oct 11, 2022
sebbousquet
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the marker extraction to also extract enum members to improve i18n files generation.
Removes the limitation that was in place on the query of
CallExpressionto allowPropertyAccessExpression. This allows to get markers with Enum. By testing the structure of theExpression, we gather the information relative to the enum member that we are looking for. By browsing the files that contain the enumeration (whether locally or in the imports of the file), we can find the value that the enum member was initialized to. If the value is of typestringwe keep it in the extracted list.