Resolve node modules correctly inside symlinked plugins #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.68% (diff: 100%)@@ master #1686 diff @@
==========================================
Files 254 254
Lines 13871 13871
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 12576 12579 +3
+ Misses 1295 1292 -3
Partials 0 0
|
zachmullen
approved these changes
Nov 29, 2016
|
This nodejs/node issue on fixing symlinks might be of interest to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an unfortunate issue resolving node modules from files symlinked from outside of the main girder path. It came up in the large_image plugin when trying to resolve the external geojs dependency. It looks like the node developers are treating it as a WONTFIX. See here for the gory details: nodejs/node#3402.
In terms of the fix here, it would be better if I could inject the
NODE_PATHenvironment variable inside theGruntfile.js, but it looks like that variable needs to be set before loading the script. This probably breaks windows builds, but I can't think of any other way to do it besides telling users to always set that environment variable manually.