Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ReScript 11's uncurried mode #269

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

fhammerschmidt
Copy link
Contributor

ReScript 11 introduces uncurried mode which sacrifices automatic partial application for an explicit syntax.

However, libraries probably should not switch to it (yet). If I changed everything to

let active = pseudoClass("active", ...)

this project would not build anymore for ReScript < 11 users.

So the saner thing to do was to just unwrap all calls and explicitly put the arg there.

@giraud giraud merged commit 8e4da79 into giraud:master Jun 19, 2023
@giraud
Copy link
Owner

giraud commented Jun 19, 2023

thanks

@fhammerschmidt fhammerschmidt deleted the support-uncurried-mode branch June 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants