Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add textShadows #125

Merged
merged 2 commits into from
Apr 4, 2019
Merged

add textShadows #125

merged 2 commits into from
Apr 4, 2019

Conversation

Freddy03h
Copy link
Contributor

Add textShadows following implementation of boxShadows

@giraud giraud merged commit 0d5410d into giraud:master Apr 4, 2019
@giraud
Copy link
Owner

giraud commented Apr 4, 2019

Thanks, merged. but I prefer to keep more conservative comments with /* */

@Freddy03h
Copy link
Contributor Author

Freddy03h commented Apr 4, 2019 •
edited
Loading

Thank's for the merge !

For the comments, what's your configuration ? /* */ is broken in VSCode with reason-vscode.

Also, I'm new to Reason , but I find weird to see 'shadow and 'textShadow in ruleToJs at the same level with 'declaration and 'selector and can possibly grow with other "list rules" like shadow and textShadow. Any refactor idea to help ?

@giraud
Copy link
Owner

giraud commented Apr 4, 2019

I'm not using VSCode so I can't help.
you're right for shadow and textshadow, I didn't realize that. I don't know what should be done right now, but it needs some reflexion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freddy03h @giraud