Skip to content

Commit

Permalink
correct issue with session replay live mode and bundled css (highligh…
Browse files Browse the repository at this point in the history
…t#9186)

## Summary

rrweb-io/rrweb#1458 introduced issues with
certain customers' applications such as:
```js
Uncaught CssSyntaxError: <css input>:1778:83: Unknown word
Uncaught CssSyntaxError: <css input>:1:65502: Unknown word
Uncaught CssSyntaxError: <css input>:1:2: Unclosed block
```

example of such a session:
https://app.highlight.io/92422/sessions/qGaSpGVNh4Ewqj8k23lNC5zNtcB1
affected highlight.run clients are >=9.1.5 with certain bundled CSS

this may also affect the replayer so the new frontend usage of rrweb is
affected

## How did you test this change?

fixes playback of [session that used to not
play](https://app.highlight.io/92422/sessions/qGaSpGVNh4Ewqj8k23lNC5zNtcB1)
<img width="1487" alt="Screenshot 2024-08-19 at 15 54 49"
src="https://github.com/user-attachments/assets/305779eb-6ee4-489f-999c-3c608f04d86b">

new client build working
<img width="1403" alt="Screenshot 2024-08-19 at 16 07 24"
src="https://github.com/user-attachments/assets/f6a46f8f-827f-42b0-acc2-cd01fc2ae249">

## Are there any deployment considerations?

new changeset

## Does this work require review from our design team?

no
  • Loading branch information
Vadman97 authored Aug 20, 2024
1 parent 61be708 commit 262a073
Show file tree
Hide file tree
Showing 4 changed files with 1,122 additions and 8,024 deletions.
7 changes: 7 additions & 0 deletions .changeset/chilled-ads-change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'highlight.run': patch
---

revert postcss changes to css parsing in rrweb
https://github.com/rrweb-io/rrweb/pull/1458 introduced
a new CSS parser which causes issues with certain large CSS files
Loading

0 comments on commit 262a073

Please sign in to comment.