Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Authentification obligatoire sur l'API #1628

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

Guilouf
Copy link
Collaborator

@Guilouf Guilouf commented Jan 7, 2025

Quoi ?

Ne plus autoriser les utilisateur à accéder librement à l'API

Pourquoi ?

Les utilisateurs se connectent trop en anonyme, on ne peut pas faire de stats dessus

Comment ?

  • Exiger l'authentification sur chaque appel à l'API
  • Modifier la documentation en conséquence

@Guilouf Guilouf added the enhancement New feature or request label Jan 7, 2025
@Guilouf Guilouf self-assigned this Jan 7, 2025
@Guilouf Guilouf marked this pull request as ready for review January 13, 2025 10:27
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste quelques remarques sur les tests. Il faut ajuster le nom des tests quand on prend désormais une 401 et il faut continuer de voir si on a bien les données quand on est connecté.

Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG !

Copy link

gitguardian bot commented Feb 4, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Guilouf Guilouf force-pushed the guilouf/auth-api branch 2 times, most recently from a83cb45 to 7fc2bef Compare February 7, 2025 10:45
@Guilouf Guilouf force-pushed the guilouf/auth-api branch 2 times, most recently from 3399ad3 to 0084d1c Compare February 20, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants