Major Refactoring and UI Improvements #4
Merged
+437
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 24, 2024 16:32
- Fix navigation issue to AboutUsScreen - Reintroduce navigateTo() util function
Now showSnackBar() and showErrorSnackBar() are wrapper functions of _showSnackBar().
- Turn buildCard() function into a ResultCard widget - Replace all occurrences of buildCard() with the new widget
- Fix issues with storage permissions - ResultCard widget now doesn't show copy button if it's in error mode - Replace buildCard() with ResultCard widget - Other minor refactors
- Convert HomeState into a sealed class, with each UI state now is rapresented by a subclass of HomeState - idle state: HomeStateIdle - loading state: HomeStateLoading - success state: HomeStateSuccess - error state: HomeStateError Thanks to this change: - The HashBruteforcingResult isn't exposed to HomeScreen - _renderCrackingResult() is renamed to _renderBasedOnState() which internally uses a switch statement who simplfies the conditionally rendering of widgets based on the current state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to improve code structure and user experience:
Code Refactoring:
Extracted hash-related utilities into a dedicated Hasher class for better organization.
Refactored HomeScreen for improved maintainability and readability.
Renamed HashCracker to HashBruterforcer for better accuracy.
New Features:
Added HashAlgorithmSelector widget to provide a user-friendly way to choose hash algorithms.
Implemented ResultCard widget for displaying hash cracking results.
Introduced showSnackBar function for displaying in-app notifications.
UI Enhancements:
Converted HomeScreen to a HookWidget for better state management.