Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 7.3 #120

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Add support for PHP 7.3 #120

merged 1 commit into from
Jan 27, 2019

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jan 26, 2019

No description provided.

@pamil pamil closed this Jan 26, 2019
@pamil pamil reopened this Jan 26, 2019
@giorgiosironi
Copy link
Owner

PHP 7.3 has been released at the beginning of December 2018. The test suite passes and composer.json doesn't lock you into a particular 7.x version. There is a requirement for PHPUnit versions but that is usually dealt with separately.

@giorgiosironi giorgiosironi merged commit edefd6a into giorgiosironi:master Jan 27, 2019
@giorgiosironi
Copy link
Owner

Thank you for the contribution, I have also added it to the ChangeLog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorgiosironi giorgiosironi giorgiosironi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pamil @giorgiosironi