Expand hipSPARSE bindings for complex types #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
approved these changes
Jan 30, 2024
|
We dont test any of these. Maybe we should think about having capabilities to more comprehensive typed unit tests ? Probably not to run with our regular CI, as that would consume too much time, but something that we could run if necessary, or maybe before a release to ensure that all types work well. |
|
Tagging #534 here. I don't agree that testing all of them is too much of a burden, one full HIP GPU pipeline I just ran on FTP takes only 3-4 minutes when built in Release shared. I think instead we should consider cutting down on our debug and static builds and/or using our |
upsj
approved these changes
Feb 9, 2024
MarcelKoch
approved these changes
Feb 9, 2024
4c48eab to
a9b7c34
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hipSPARSE has improved its complex support, so we can add complex types to these routines.