-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename test binaries that collide with C++ standard library header names #1531
Conversation
I think it might be a bit annoying to maintain these lists ? Maybe we can prefix all test executables with a unique prefix/suffix like |
I don't think it's that much effort, the list of C++ standard library headers is pretty short and doesn't change a lot, and we don't have many tests that overlap the list. That's something we can do during code review. |
To go a bit more into detail why I dislike adding a prefix/suffix to all tests: I like being able to just build a single test binary via |
I see. That makes sense. Usually in my case, it is multiple targets that are relevant, so I end up doing a regex match with ninja -t targets | grep ^foo | sed 's/:.*//' > my_targets so a suffix/prefix does not affect this. and then you can just run |
What we could do there (and what I did before) is add meta-targets that compile certain parts of the library, e.g. a |
55466b5
to
90772a6
Compare
This gets rid of all the
CPATH
issues we've been having from time to time by renaming all test binaries that match a C++ standard library header name.Fixes #1530