Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output build runtime in CI and split up further HIP kernels #1384

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Output build runtime in CI and split up further HIP kernels #1384

merged 3 commits into from
Aug 11, 2023

Conversation

upsj
Copy link
Member

@upsj upsj commented Aug 10, 2023

I forgot to add this output again in a previous PR.

The debug builds for ROCm take 3000-4000s to build just the mixed-precision SpMV kernels.
This PR improves that by splitting up the instantiation of mixed-precision kernels even further.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Aug 10, 2023
@upsj upsj requested a review from a team August 10, 2023 16:59
@upsj upsj self-assigned this Aug 10, 2023
@ginkgo-bot ginkgo-bot added reg:ci-cd This is related to the continuous integration system. mod:core This is related to the core module. type:matrix-format This is related to the Matrix formats mod:hip This is related to the HIP module. labels Aug 10, 2023
@upsj upsj added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Aug 10, 2023
@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@upsj upsj merged commit 0dfcbb6 into develop Aug 11, 2023
@upsj upsj deleted the build_runtime branch August 11, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@tcojean tcojean tcojean approved these changes

Assignees

@upsj upsj

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. mod:hip This is related to the HIP module. reg:ci-cd This is related to the continuous integration system. type:matrix-format This is related to the Matrix formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upsj @pratikvn @MarcelKoch @tcojean @ginkgo-bot