-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfaults due to executor generation in examples #594
Comments
The issue should be caused by I discussed it with @tcojean before, and he has some idea to fix it. |
I vaguely recall us also having some issues with cuSPARSE handles being destroyed twice or something similar? Or was that also caused by the device reset? |
I created a PR. But I was wondering, since creating executors by its name is such a common operation, if it should be moved to a dedicated function? |
I'm not entirely sure about this. Since these are examples, they should be as self-contained as possible, and I'm not sure whether users would need this functionality in the library. |
Some of our examples use an executor map
Executing these tests with HIP and CUDA compiled causes a segmentation fault in my tests, probably due to the CUDA and HIP executor destroying the same device and/or library handles (hipSPARSE etc.)
This should be fixed by only creating the executor on demand, like in the benchmark examples (replacing std::shared_ptr<...> by std::function<std::shared_ptr<...>()> and using lambdas)
The text was updated successfully, but these errors were encountered: