Skip to content

Commit

Permalink
fix issues with deleted files in format step
Browse files Browse the repository at this point in the history
  • Loading branch information
upsj committed Apr 8, 2021
1 parent 4b6af90 commit af16736
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/bot-pr-base.sh
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ bot_get_all_changed_files() {
while true; do
# this api allows 100 items per page
# github action uses `bash -e`. The last empty page will leads jq error, use `|| :` to ignore the error.
local pr_page_files=$(api_get "$pr_url/files?&per_page=100&page=${page}" | jq -er '.[] | .filename' || :)
local pr_page_files=$(api_get "$pr_url/files?&per_page=100&page=${page}" | jq -er '.[] | select(.status != "removed") | .filename' || :)
if [ "${pr_page_files}" = "" ]; then
break
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/bot-pr-format-base.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ cp /tmp/format_header.sh dev_tools/scripts/
cp /tmp/update_ginkgo_header.sh dev_tools/scripts/

# format files
CLANG_FORMAT=clang-format-8
CLANG_FORMAT=clang-format-9
dev_tools/scripts/add_license.sh
dev_tools/scripts/update_ginkgo_header.sh
for f in $(echo "$TO_FORMAT" | grep -E $FORMAT_HEADER_REGEX); do dev_tools/scripts/format_header.sh "$f"; done
Expand Down

0 comments on commit af16736

Please sign in to comment.