deprecate old variables

.github/workflows/windows-mingw.yml

@@ -50,7 +50,7 @@ jobs:
         set PATH=C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\bin;%PATH%
         mkdir build
         cd build
-        cmake -G "MinGW Makefiles" -DBUILD_SHARED_LIBS=${{ matrix.config.shared }} -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} -DGINKGO_COMPILER_FLAGS=${{ matrix.config.cflags }} ..
+        cmake -G "MinGW Makefiles" -DBUILD_SHARED_LIBS=${{ matrix.config.shared }} -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} -DCMAKE_CXX_FLAGS=${{ matrix.config.cflags }} ..
         cmake --build . -j4
       shell: cmd
 

CMakeLists.txt

@@ -74,6 +74,8 @@ option(GINKGO_FORCE_GPU_AWARE_MPI "Assert that the MPI library is GPU aware. Thi
      catastrophically in case the MPI implementation is not GPU Aware, and GPU aware functionality has been forced" OFF)
 set(GINKGO_CI_TEST_OMP_PARALLELISM "4" CACHE STRING
     "The number of OpenMP threads to use for a test binary during CTest resource file-constrained test.")
+gko_rename_cache(GINKGO_COMPILER_FLAGS CMAKE_CXX_FLAGS BOOL "Flags used by the CXX compiler during all build types.")
+gko_rename_cache(GINKGO_CUDA_COMPILER_FLAGS CMAKE_CUDA_FLAGS BOOL "Flags used by the CUDA compiler during all build types.")
 
 # load executor-specific configuration
 if(GINKGO_BUILD_CUDA)

CONTRIBUTING.md

@@ -586,14 +586,9 @@ files.
 
 ### Warnings
 
-By default, the `-DGINKGO_COMPILER_FLAGS` is set to `-Wpedantic` and hence
-pedantic warnings are emitted by default. Some of these warnings are false
-positives and a complete list of the resolved warnings and their solutions is
-listed in [Issue 174](https://github.com/ginkgo-project/ginkgo/issues/174).
-Specifically, when macros are being used, we have the issue of having `extra ;`
-warnings, which is resolved by adding a `static_assert()`. The CI system
-additionally also has a step where it compiles for pedantic warnings to be
-errors.
+By default, the `-DCMAKE_CXX_FLAGS` should be set to `-Wpedantic` to emit
+pedantic warnings by default. The CI system additionally also has a step
+where it compiles for pedantic warnings to be errors.
 
 ### Avoiding circular dependencies
 

INSTALL.md

@@ -45,7 +45,9 @@ Ginkgo adds the following additional switches to control what is being built:
 *   `-DGINKGO_BUILD_SYCL={ON, OFF}` builds optimized SYCL versions of the
     kernels (requires `CMAKE_CXX_COMPILER` to be set to the `dpcpp` or `icpx` compiler).
     The default is `ON` if `CMAKE_CXX_COMPILER` is a SYCL compiler, `OFF`
-    otherwise.
+    otherwise. Due to some differences in IEEE 754 floating point numberhandling in the Intel
+    SYCL compilers, Ginkgo tests may fail unless compiled with
+    `-DCMAKE_CXX_FLAGS=-ffp-model=precise`
 *   `-DGINKGO_BUILD_HIP={ON, OFF}` builds optimized HIP versions of the kernels
     (requires HIP), default is `ON` if an installation of HIP could be detected,
     `OFF` otherwise.