Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nonce to ID token #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added nonce to ID token #335

wants to merge 1 commit into from

Conversation

Jxlle
Copy link

@Jxlle Jxlle commented Jul 4, 2023

Proposed changes

The iSHARE OIDC flow created ID tokens without a nonce claim. The SELECT statement for getting oauth information from the database missed the 'nonce' attribute. This attribute has now been added.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)

Checklist

  • I have read the
    CONTRIBUTING
    doc
  • I have signed the
    CLA
  • I have added necessary documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature
    works
  • Any dependent changes have been merged and published in downstream
    modules

Further comments

No further comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@Jxlle
Copy link
Author

Jxlle commented Jul 4, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant