not print color log when go version is 1.10/1.11

[thinkerou]

• With issues:

  • Use the search tool before opening a new issue.
  • Please provide source code and commit sha if you found a bug.
  • Review existing issues and provide feedback or react to them.

• go version: go 1.11

• gin version (or commit ref): master

• operating system: mac

Description

Here can see go 1.8 1.9 1.10 1.11 print log: https://travis-ci.org/gin-gonic/gin/builds/428455260?utm_source=github_status&utm_medium=notification

when go version is 1.9 it will print log:

else print log:

Screenshots

[thinkerou]

println(isatty.IsTerminal(os.Stdout.Fd())) on https://github.com/gin-gonic/gin/blob/master/logger.go#L60 will print false on go 1.11, but println(isatty.IsTerminal(os.Stdout.Fd())) on single file will print true on go 1.11. I don't know why?

[thinkerou]

ping @mattn @thesyncim thanks

[mattn]

I didn't change anything for mac. (as far as I remember)

[thinkerou]

@mattn thank you for yourreply.

[BrandonZacharie]

I got colors on macOS High Sierra and now Mojave. I only lose colors when running gin (i.e. gin -p 5000 -i run main.go) which wraps the process.

[kaustubhmallik]

@thinkerou will you be able to pick it, otherwise, I would love to help.

[thinkerou]

@kamronbatman welcome