Add .size_hint() implementation for ArchiveSymbolIterator
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the size hint value from the underlying `slice::Iter`. The iterator itself does not track the symbol count so this slice iter provides the most accurate value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.size_hint()implementation to theArchiveSymbolIterator.The value returned for this is the size hint value of the underlying
slice::Iter. This provides the most accurate size hint without needing to add additional fields for keeping track of the iterator's state.I have been working on a project where it would be nice to pre-allocate collections based on the number of symbols inside an archive's symbol map. The default
.size_hint()implementation returns 0 and there is no API in this library that will get this value.